Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove static properties from helpers #1575

Merged
merged 1 commit into from
Dec 5, 2019

Conversation

Andarist
Copy link
Contributor

@Andarist Andarist commented Dec 4, 2019

Static properties used like this at the top-level are a common tree-shaking / dead code elimination deopt (because they affect other top-level statements) so ideally, this pattern should be avoided as much as possible.

This is the last PR from me today - I'd like to see how those play out first, but I have more changes planned.

@vercel
Copy link

vercel bot commented Dec 4, 2019

This pull request is being automatically deployed with ZEIT Now (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://zeit.co/markedjs/markedjs/kmea584ch
🌍 Preview: https://markedjs-git-fork-andarist-remove-statics-from-helpers.markedjs.now.sh

Copy link
Member

@styfle styfle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this reads much better now, thanks 👍

@UziTech UziTech merged commit edf87e3 into markedjs:master Dec 5, 2019
@UziTech UziTech mentioned this pull request Dec 5, 2019
12 tasks
This was referenced Dec 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants