Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix GFM Example 116 #1600

Merged
merged 1 commit into from
Feb 11, 2020
Merged

Fix GFM Example 116 #1600

merged 1 commit into from
Feb 11, 2020

Conversation

calculuschild
Copy link
Contributor

@calculuschild calculuschild commented Feb 10, 2020 •
edited by styfle
Loading

Marked version: 8.0

Markdown flavor: CommonMark & GitHub Flavored Markdown

Description

Also adds tests for detection of these fences if they should or not break paragraphs.

Implementing code as discussed in #1598 (comment)

Contributor

  • Test(s) exist to ensure functionality and minimize regression

Committer

In most cases, this should be a different person than the contributor.

  • Draft GitHub release notes have been updated.
  • CI is green (no forced merge required).
  • Merge PR

@calculuschild
Fix GFM Example 116
63454d2 
Only code fences made from backticks cannot have other backticks in the same line. Fences with tildes can have both tildes and backticks. This allows the tilde case to work correctly.

Also test for detection of these fences as they break or do not break paragraphs.
@vercel
Copy link

vercel bot commented Feb 10, 2020

This pull request is being automatically deployed with ZEIT Now (learn more).
To see the status of your deployment, click on the icon next to each commit.

@calculuschild calculuschild mentioned this pull request Feb 10, 2020
Merged
4 tasks
UziTech
UziTech approved these changes Feb 11, 2020
View reviewed changes
Copy link
Member

@UziTech UziTech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm 🚢

@calculuschild
Copy link
Contributor Author

Cool. Does anything else need to happen to merge this?

calculuschild added a commit to calculuschild/marked that referenced this pull request Feb 11, 2020
@calculuschild
Update fences after tables regex
5972e73 
Fences after tables fixed in line with PR markedjs#1600.
@vercel vercel bot requested a deployment to Preview February 11, 2020 18:06 Abandoned
@vercel
Copy link

vercel bot commented Feb 11, 2020

Deployment failed with the following error:

Configuring `regions` is not necessary for Static Files. Deploying Serverless Functions to multiple regions is restricted to paid plans. Upgrade here: https://zeit.co/teams/markedjs/settings/billing.

styfle
styfle approved these changes Feb 11, 2020
View reviewed changes
Copy link
Member

@styfle styfle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! 🎉

@styfle styfle merged commit 1f96816 into markedjs:master Feb 11, 2020
@UziTech UziTech mentioned this pull request Mar 6, 2020
Merged
12 tasks
@rhymes rhymes mentioned this pull request Mar 19, 2020
Merged
This was referenced Mar 21, 2020
Closed
Merged
Merged
Open
Merged
Merged
This was referenced Mar 30, 2020
Open
Open
This was referenced Apr 9, 2020
Closed
Merged
Open
Closed
Open
Closed
Merged
Open
@restinpeaceinout restinpeaceinout mentioned this pull request Sep 12, 2024
Open
@basantMishra2956 basantMishra2956 mentioned this pull request Sep 12, 2024
Open
@ryanmichaelfabayos ryanmichaelfabayos mentioned this pull request Sep 12, 2024
Open
@prashanty0246 prashanty0246 mentioned this pull request Sep 12, 2024
Open
@P-Varshney08 P-Varshney08 mentioned this pull request Sep 13, 2024
Open
@FullBeardDev FullBeardDev mentioned this pull request Sep 13, 2024
Open
@basantMishra2956 basantMishra2956 mentioned this pull request Sep 13, 2024
Open
@IT21168222 IT21168222 mentioned this pull request Sep 13, 2024
Open
@vinit-aikido vinit-aikido mentioned this pull request Sep 13, 2024
Open
@P-Varshney08 P-Varshney08 mentioned this pull request Sep 14, 2024
Open
@basantMishra2956 basantMishra2956 mentioned this pull request Sep 14, 2024
Open
@atlslscsrv-app atlslscsrv-app mentioned this pull request Sep 14, 2024
Open
@FullBeardDev FullBeardDev mentioned this pull request Sep 14, 2024
Open
@prashanty0246 prashanty0246 mentioned this pull request Sep 14, 2024
Open
@ollijarva0 ollijarva0 mentioned this pull request Sep 14, 2024
Open
@P-Varshney08 P-Varshney08 mentioned this pull request Sep 15, 2024
Open
@FullBeardDev FullBeardDev mentioned this pull request Sep 15, 2024
Open
@basantMishra2956 basantMishra2956 mentioned this pull request Sep 15, 2024
Open
@P-Varshney08 P-Varshney08 mentioned this pull request Sep 16, 2024
Open
@basantMishra2956 basantMishra2956 mentioned this pull request Sep 17, 2024
Open
@FullBeardDev FullBeardDev mentioned this pull request Sep 17, 2024
Open
@anashope anashope mentioned this pull request Sep 17, 2024
Open
@basantMishra2956 basantMishra2956 mentioned this pull request Sep 17, 2024
Open
This was referenced Sep 18, 2024
Open
Open
@FullBeardDev FullBeardDev mentioned this pull request Sep 18, 2024
Open
@OATEF4313 OATEF4313 mentioned this pull request Sep 18, 2024
Open
@basantMishra2956 basantMishra2956 mentioned this pull request Sep 19, 2024
Open
@P-Varshney08 P-Varshney08 mentioned this pull request Sep 19, 2024
Open
@FullBeardDev FullBeardDev mentioned this pull request Sep 19, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@UziTech UziTech UziTech approved these changes

@styfle styfle styfle approved these changes

Assignees
No one assigned
Labels
category: code blocks
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@calculuschild @UziTech @styfle