Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix GFM Example 116 #1600

Merged
merged 1 commit into from
Feb 11, 2020
Merged

Fix GFM Example 116 #1600

merged 1 commit into from
Feb 11, 2020

Conversation

calculuschild
Copy link
Contributor

@calculuschild calculuschild commented Feb 10, 2020

Marked version: 8.0

Markdown flavor: CommonMark & GitHub Flavored Markdown

Description

Also adds tests for detection of these fences if they should or not break paragraphs.

Implementing code as discussed in #1598 (comment)

Contributor

  • Test(s) exist to ensure functionality and minimize regression

Committer

In most cases, this should be a different person than the contributor.

  • Draft GitHub release notes have been updated.
  • CI is green (no forced merge required).
  • Merge PR

Only code fences made from backticks cannot have other backticks in the same line. Fences with tildes can have both tildes and backticks. This allows the tilde case to work correctly.

Also test for detection of these fences as they break or do not break paragraphs.
@vercel
Copy link

vercel bot commented Feb 10, 2020

This pull request is being automatically deployed with ZEIT Now (learn more).
To see the status of your deployment, click on the icon next to each commit.

Copy link
Member

@UziTech UziTech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm 🚢

@calculuschild
Copy link
Contributor Author

Cool. Does anything else need to happen to merge this?

calculuschild added a commit to calculuschild/marked that referenced this pull request Feb 11, 2020
Fences after tables fixed in line with PR markedjs#1600.
@vercel vercel bot requested a deployment to Preview February 11, 2020 18:06 Abandoned
@vercel
Copy link

vercel bot commented Feb 11, 2020

Deployment failed with the following error:

Configuring `regions` is not necessary for Static Files. Deploying Serverless Functions to multiple regions is restricted to paid plans. Upgrade here: https://zeit.co/teams/markedjs/settings/billing.

Copy link
Member

@styfle styfle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! 🎉

@styfle styfle merged commit 1f96816 into markedjs:master Feb 11, 2020
@UziTech UziTech mentioned this pull request Mar 6, 2020
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants