Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

render code with and without language with the trailing newline #1670

Merged
merged 1 commit into from
May 11, 2020

Conversation

devoto13
Copy link
Contributor

@devoto13 devoto13 commented May 10, 2020

Marked version:

1.0.0

Markdown flavor: n/a

Expectation

Code blocks with and without language are both rendered with the trailing new line.

Result

Code block with language has trailing newline, but code block without language does not.

What was attempted

?

Contributor

  • Test(s) exist to ensure functionality and minimize regression (if no tests added, list tests covering this PR)

Committer

In most cases, this should be a different person than the contributor.

  • Draft GitHub release notes have been updated.
  • CI is green (no forced merge required).
  • Merge PR

@vercel
Copy link

vercel bot commented May 10, 2020

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/markedjs/markedjs/e5nqmxelz
✅ Preview: https://markedjs-git-fork-devoto13-code-newline.markedjs.now.sh

Copy link
Member

@styfle styfle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Copy link
Member

@UziTech UziTech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work! 🚢

@UziTech UziTech merged commit 31f8379 into markedjs:master May 11, 2020
@UziTech UziTech mentioned this pull request May 16, 2020
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants