Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add module field to package.json #2020

Closed
wants to merge 1 commit into from
Closed

Conversation

benmccann
Copy link
Contributor

Marked version: latest

Markdown flavor: n/a

Description

module is the standard used to describe the ESM entry point

Contributor

  • Test(s) exist to ensure functionality and minimize regression (if no tests added, list tests covering this PR); or,
  • no tests required for this PR.
  • If submitting new feature, it has been documented in the appropriate places.

Committer

In most cases, this should be a different person than the contributor.

@vercel
Copy link

vercel bot commented Apr 20, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/markedjs/markedjs/8tQw4jQ1bwTt76tNUXMwuQYLMEj9
✅ Preview: https://markedjs-git-fork-benmccann-patch-1-markedjs.vercel.app

@UziTech
Copy link
Member

UziTech commented Apr 20, 2021

looks like we removed the module field in #1581 because of an issue in webpack (discussion).

@benmccann
Copy link
Contributor Author

Ok. I opened an issue instead since it seems a bit more complicated than this

@benmccann benmccann closed this Apr 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants