Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Remove esm interop #2225

Merged
merged 1 commit into from
Oct 6, 2021
Merged

fix: Remove esm interop #2225

merged 1 commit into from
Oct 6, 2021

Conversation

benmccann
Copy link
Contributor

Marked version: 3.0.5

Markdown flavor: all

Description

Alternative to #2224

Contributor

  • Test(s) exist to ensure functionality and minimize regression (if no tests added, list tests covering this PR); or,
  • no tests required for this PR.
  • If submitting new feature, it has been documented in the appropriate places.

Committer

In most cases, this should be a different person than the contributor.

@vercel
Copy link

vercel bot commented Oct 6, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/markedjs/markedjs/7PPFvf6umYgKWUcnD6Js93uzFjae
✅ Preview: https://markedjs-git-fork-benmccann-esm-interop-markedjs.vercel.app

@UziTech UziTech changed the title Remove esm interop fix: Remove esm interop Oct 6, 2021
@UziTech UziTech merged commit 4bc9121 into markedjs:master Oct 6, 2021
github-actions bot pushed a commit that referenced this pull request Oct 6, 2021
## [3.0.6](v3.0.5...v3.0.6) (2021-10-06)

### Bug Fixes

* Remove esm interop ([#2225](#2225)) ([4bc9121](4bc9121))
@github-actions
Copy link

github-actions bot commented Oct 6, 2021

🎉 This PR is included in version 3.0.6 🎉

The release is available on:

Your semantic-release bot 📦🚀

@UziTech
Copy link
Member

UziTech commented Oct 6, 2021

This still seems to have not fixed it.

@benmccann
Copy link
Contributor Author

I will take a look now that I know what the issue is and see if I can come up with a better fix

@thexs-dev
Copy link

I was using this import line:
import * as marked from 'https://cdn.jsdelivr.net/npm/marked@3.0/lib/marked.js';

And the web app broke with 3.0.6 release
I had to rollback to 3.0.4 to get it back

How should I import marked now from cdn.jsdelivr.net/npm/marked?

@UziTech
Copy link
Member

UziTech commented Oct 7, 2021

@thexs-dev v3.0.7 should work again

@thexs-dev
Copy link

This import line is working fine 3.0.7 as suggested above, but not for 4.0
import * as marked from 'https://cdn.jsdelivr.net/npm/marked@3.0.7/lib/marked.js';

I know it's a trivial question, but I don't know the answer
How can I adapt that import line to load marked@4.0 ?
Thanks in advance

@styfle
Copy link
Member

styfle commented Nov 19, 2021

Try the ESM file

https://cdn.jsdelivr.net/npm/marked@4.0.3/lib/marked.esm.js

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants