fix: spaces on a newline after a table

[cyanxiao]

Marked version: 4.0.7

Markdown flavor: Markdown.pl|CommonMark|GitHub Flavored Markdown|n/a

Description

• Fixes Error thrown if there's a space on a newline after a table #2249
  The problem can be solved by removing the last table row with no data. The row matching /^ {1,4}$/ should be removed. There is no need to deal with /^ {5,}$/ since more than 4 spaces would be parsed to a fenced code block.

Contributor

• Test(s) exist to ensure functionality and minimize regression (if no tests added, list tests covering this PR); or,
• no tests required for this PR.
• If submitting new feature, it has been documented in the appropriate places.

Committer

In most cases, this should be a different person than the contributor.

• CI is green (no forced merge required).
• Squash and Merge PR following conventional commit guidelines.

[vercel]

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/markedjs/markedjs/8R4yxox13gcfwaQktGJmJxcEEPoW
✅ Preview: https://markedjs-git-fork-imchell-master-markedjs.vercel.app

[UziTech]

does this fix #2278 as well?

[cyanxiao]

No, it is for #2249 solely. #2278 is getting TypeError exception for a similar reason, but the parsing result is not the same as commonmark.js even the exception is fixed. I will look into that.

[cyanxiao]

There are no exceptions both for #2249 and #2278 now, but the parsing result of #2278 may differ from commonmark.js because of the ambiguity between gfm table and setext heading ( #1499 ).

[UziTech]

after a little bit of experimenting it looks like a better fix would be to change the line:

-        rows: cap[3] ? cap[3].replace(/\n$/, '').split('\n') : []
+        rows: cap[3] ? cap[3].replace(/\n[ \t]*$/, '').split('\n') : []

basically removing any trailing space characters before creating rows.

This would allow removing more than 4 spaces without affecting fenced code blocks inside the table.

[cyanxiao]

Thanks. It's a better solution.

[UziTech]

@imchell can you make that change and leave the test to make sure it works?

[cyanxiao]

@UziTech updated 👀

[UziTech]

Thanks! 💯

[github-actions]

🎉 This PR is included in version 4.0.8 🎉

The release is available on:

• npm package (@latest dist-tag)
• GitHub release

Your semantic-release bot 📦🚀