forked from zalmoxisus/redux-devtools-extension
-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Convert NPM package to TS #1
Closed
markerikson
wants to merge
104
commits into
markerikson:master
from
reduxjs:feature/convert-package-to-ts
Closed
Convert NPM package to TS #1
markerikson
wants to merge
104
commits into
markerikson:master
from
reduxjs:feature/convert-package-to-ts
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The correct possessive form of "Redux" is "Redux's", not "Redux'". Sources: * https://ell.stackexchange.com/questions/6295/when-a-word-ends-in-s-or-x-do-you-add-s-or-just-an * https://www.dictionary.com/e/how-do-you-use-an-apostrophe/
Code of package runs in production, thus we should install it with --save, not with --save-dev fixes zalmoxisus#681
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR attempts to fork the the
redux-devtools-extension
NPM package and convert it to TypeScript:redux-devtools-extension
to@reduxjs/redux-devtools-extension-fork
index.ts
entry pointApparently TSDX does not support multiple entry points atm ( jaredpalmer/tsdx#175 ), but we only rely on the one entry point in RTK anyway.
I've already gone ahead and published this package as
0.0.1
on NPM ( https://www.npmjs.com/package/@reduxjs/redux-devtools-extension-fork ), to help verify that it works as expected with RTK.