New exception message is confusing

[sravanr]

Regression test TestCRUDModulesDb is failing in nightly regression

public void testXQueryModuleCRUDXmlFileNegative() {

    DatabaseClient client = DatabaseClientFactory.newClient("localhost", 8011, "rest-admin", "x", Authentication.DIGEST);

    // get a manager
    ExtensionLibrariesManager libsMgr = client.newServerConfigManager().newExtensionLibrariesManager();

    String Path = "/foo/my/path/to/my/module.xqy";
    FileHandle f = new FileHandle(new File("src/test/java/com/marklogic/javaclient/data/all_well.xml")).withFormat(Format.XML);

    // write XQuery file to the modules database
    try{
    libsMgr.write(Path, f);
    }catch(ResourceNotFoundException e){
        assertEquals("Negative test Passed as","Local message: Could not write resource at /foo/my/path/to/my/module.xqy. Server Message: /v1/foo/my/path/to/my/module.xqy" , e.getMessage());
    }
    // delete it
    try{
        libsMgr.delete(Path);
    }catch(Exception e){
        assertEquals("", "Local message: Could not delete resource at /foo/my/path/to/my/module.xqy. Server Message: /v1/foo/my/path/to/my/module.xqy", e.getMessage());
    }

}

Actual:
Local message: Could not write resource at /foo/my/path/to/my/module.xqy. Server Message: Request failed. Error body not received from server

[sammefford]

Sravan, can you help me understand what's happening here? The inline comments don't clarify it for me. It looks like you're writing a valid module. Yet the method name implies to me these are negative tests. Are these? If so, why do they fail?

I need to translate this into REST language to send this error on to the lower layers.

[sravanr]

This an existing test in regression which started failing because of exception message mismatch, I have not tried in understanding the test but I see the message it is spitting now is confusing, here is the complete test for your reference
https://github.com/marklogic/java-client-api/blob/dev/test-complete/src/test/java/com/marklogic/javaclient/TestCRUDModulesDb.java

[sammefford]

The error changed in lower layers, so I need to create an issue for them. Can you provide a wire trace? That should help the most.

[sammefford]

@srinathgit can you verify that this test is no longer failing? I'm guessing this issue has just lingerred unnecessarily.

[srinathgit]

Assigning the case to @georgeajit

[srinathgit]

@sammefford The same (confusing) exception is still being thrown "Local message: Could not write resource at /foo/my/path/to/my/module.xqy. Server Message: Request failed. Error body not received from server". But the test has been changed as below and so it passess

@Test
public void testXQueryModuleCRUDXmlFileNegative() throws KeyManagementException, NoSuchAlgorithmException, IOException {
	
	DatabaseClient client = getDatabaseClient("rest-admin", "x", Authentication.DIGEST);
	
	// get a manager
	ExtensionLibrariesManager libsMgr = client.newServerConfigManager().newExtensionLibrariesManager();
	
	String Path = "/foo/my/path/to/my/module.xqy";
	FileHandle f = new FileHandle(new File("src/test/java/com/marklogic/client/functionaltest/data/all_well.xml")).withFormat(Format.XML);

	// write XQuery file to the modules database
	try{
	libsMgr.write(Path, f);
	}catch(ResourceNotFoundException e){
		//Issue 210 logged for meaningful error
		assertEquals("Local message: Could not write resource at /foo/my/path/to/my/module.xqy. Server Message: Request failed. Error body not received from server" , e.getMessage());
	}
	// delete it
	try{
		libsMgr.delete(Path);
	}catch(Exception e){
		assertEquals("", "Local message: Could not delete resource at /foo/my/path/to/my/module.xqy. Server Message: Request failed. Error body not received from server", e.getMessage());
	}
		
}

[sammefford]

Ok, you'll need to update that test. See the unit test I added. ExtensionLibrariesManager will now throw an IllegalStateException with the message "libraryPath (the modules database path under which you install an asset) must begin with /ext/". Let me know if you feel that message is still confusing.

[srinathgit]

The test has been modified with new exception message