Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update XOMHandle.java #1005

Merged
merged 2 commits into from
Sep 21, 2018
Merged

Conversation

anu3990
Copy link
Contributor

@anu3990 anu3990 commented Sep 21, 2018

So we can incorporate your pull request, please share the following:

  • Issue - 968

  • Are you modifying the correct branch? Yes (4.1.1-develop)

  • Version of MarkLogic Java Client API - 4.1.1

  • Version of MarkLogic Server (see admin gui on port 8001)

  • Java version (java -version)

  • OS and version

  • What Changed: What happened before this change? What happens without this change?

@anu3990 anu3990 requested a review from ehennum September 21, 2018 16:42
@anu3990 anu3990 mentioned this pull request Sep 21, 2018
Copy link
Contributor

@ehennum ehennum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does the @ deprecated JavaDoc tag have to be part of the same comment as the rest of the JavaDoc? That is, should lines 47 and 48 be deleted? Approved with that change.

@anu3990 anu3990 merged commit 65221cf into marklogic:4.1.1-develop Sep 21, 2018
@anu3990
Copy link
Contributor Author

anu3990 commented Sep 21, 2018

Merged the file after adding the changes.

@anu3990 anu3990 deleted the 4.1.1-develop branch October 1, 2018 21:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants