Skip to content

Commit

Permalink
Run build-release within build image (googleforgames#2945)
Browse files Browse the repository at this point in the history
Shifting the Cloud Build submission into the build image, so that it
utilises the credentials and configured Google Cloud project that is
set up at the beginning of the release process.

Co-authored-by: Robert Bailey <robertbailey@google.com>
  • Loading branch information
markmandel and roberthbailey authored Feb 10, 2023
1 parent 69e1a3d commit aed29cf
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions build/includes/release.mk
Original file line number Diff line number Diff line change
Expand Up @@ -96,5 +96,5 @@ do-release: $(ensure-build-image)
@echo "Now go make the $(RELEASE_VERSION) release on Github!"

build-release:
cd $(agones_path) && gcloud builds submit . --substitutions _VERSION=$(base_version) --config=./build/release/cloudbuild.yaml $(ARGS)

docker run --rm $(common_mounts) -w $(workdir_path) $(build_tag) \
gcloud builds submit . --substitutions _VERSION=$(base_version) --config=./build/release/cloudbuild.yaml $(ARGS)

0 comments on commit aed29cf

Please sign in to comment.