fix: callback argument and correct background task handling fix

markneh · Nov 14, 2020 · 796a5c5 · 796a5c5
1 parent fb47d87
commit 796a5c5
Showing 1 changed file with 6 additions and 6 deletions.
diff --git a/ios/RNESimManager.m b/ios/RNESimManager.m
@@ -35,12 +35,12 @@ @implementation RNESimManager
             request.matchingID = config[@"matchingId"];
             request.confirmationCode = config[@"confirmationCode"];
 
-            __block UIBackgroundTaskIdentifier backgroundTaskIdentifier = [[UIApplication sharedApplication] beginBackgroundTaskWithExpirationHandler:^{
-                [plan addPlanWith:request
-                completionHandler:^(CTCellularPlanProvisioningAddPlanResult result) {
-                    resolve(@(CTCellularPlanProvisioningAddPlanResultFail));
-                    [[UIApplication sharedApplication] endBackgroundTask:backgroundTaskIdentifier];
-                }];
+            // The user may send your app to the background prior to finishing the eSIM installation. To ensure your app has an opportunity to execute the completion handler and get the installation result, perform the eSIM installation as a background task. To do so, call beginBackgroundTask(expirationHandler:) prior to calling addPlan(with:completionHandler:), then call endBackgroundTask(_:) inside the completion handler.
+            UIBackgroundTaskIdentifier backgroundTaskIdentifier = [[UIApplication sharedApplication] beginBackgroundTaskWithExpirationHandler:^{}];
+
+            [plan addPlanWith:request completionHandler:^(CTCellularPlanProvisioningAddPlanResult result) {
+                resolve(@(result));
+                [[UIApplication sharedApplication] endBackgroundTask:backgroundTaskIdentifier];
             }];
         }