Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(TAGS API) fix: textarea value attribute and controllable textarea #2354

Merged
merged 1 commit into from
Nov 5, 2024

Conversation

DylanPiercey
Copy link
Contributor

No description provided.

Copy link

changeset-bot bot commented Nov 5, 2024

🦋 Changeset detected

Latest commit: 3eefdec

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
@marko/translator-tags Patch
@marko/runtime-tags Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

codecov bot commented Nov 5, 2024

Codecov Report

Attention: Patch coverage is 52.15054% with 89 lines in your changes missing coverage. Please review.

Project coverage is 87.80%. Comparing base (840eef3) to head (3eefdec).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...ges/translator-tags/src/visitors/tag/native-tag.ts 36.19% 67 Missing ⚠️
packages/runtime-tags/src/html/dynamic-tag.ts 30.00% 14 Missing ⚠️
packages/runtime-tags/src/dom/dom.ts 65.00% 7 Missing ⚠️
packages/runtime-tags/src/html/content.ts 75.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2354      +/-   ##
==========================================
- Coverage   87.80%   87.80%   -0.01%     
==========================================
  Files         343      343              
  Lines       37580    37726     +146     
  Branches     2338     2366      +28     
==========================================
+ Hits        32997    33124     +127     
- Misses       4562     4581      +19     
  Partials       21       21              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@DylanPiercey DylanPiercey merged commit a4069c2 into main Nov 5, 2024
7 of 9 checks passed
@DylanPiercey DylanPiercey deleted the controllable-textarea branch November 5, 2024 19:14
@github-actions github-actions bot mentioned this pull request Nov 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant