This repository has been archived by the owner on Sep 11, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 118
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Nice!
Sent from my T-Mobile 4G LTE Device
…-------- Original message --------
From: thempel <notifications@github.com>
Date: 3/1/18 11:48 (GMT-05:00)
To: markovmodel/PyEMMA <PyEMMA@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Subject: [markovmodel/PyEMMA] Histogram plot (#1264)
This multi-dimension histogram plot function was requested at the last pyemma workshop after I showed something similar in my presentation. It's nice to have but not very quantitative since histograms are scaled in order to be visible even for many dimensions. It produces graphs like this:
You can view, comment on, or merge this pull request online at:
#1264
Commit Summary
[plots] added dimension histogram plotting function
[plots.plots1d] added simple test for plot_feature_histograms
[plots.plots1d] better kwargs handling
[plots.plots1d] minor cosmetic changes
[plots.plots1d] arg to switch-off high dim warning for feature hist plot
[plots.plots1d] added test
File Changes
M
pyemma/plots/__init__.py
(1)
A
pyemma/plots/plots1d.py
(107)
A
pyemma/plots/tests/test_plots1d.py
(42)
Patch Links:
https://github.com/markovmodel/PyEMMA/pull/1264.patch
https://github.com/markovmodel/PyEMMA/pull/1264.diff
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or mute the thread.
{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/markovmodel/PyEMMA","title":"markovmodel/PyEMMA","subtitle":"GitHub repository","main_image_url":"https://cloud.githubusercontent.com/assets/143418/17495839/a5054eac-5d88-11e6-95fc-7290892c7bb5.png","avatar_image_url":"https://cloud.githubusercontent.com/assets/143418/15842166/7c72db34-2c0b-11e6-9aed-b52498112777.png","action":{"name":"Open in GitHub","url":"https://github.com/markovmodel/PyEMMA"}},"updates":{"snippets":[{"icon":"DESCRIPTION","message":"Histogram plot (#1264)"}],"action":{"name":"View Pull Request","url":"#1264"}}}
|
marscher
reviewed
Mar 2, 2018
pyemma/plots/plots1d.py
Outdated
n_bins : Number of bins the histogram uses. | ||
outfile : If not None, saves plot to this file. | ||
ignore_dim_warning : Enable plotting for more than 50 dimensions (on your own risk). | ||
**kwargs: Will be parsed to pyplot.fill_between when plotting the histograms. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
passed to?
Very nice figure 👍 Can you add this fancy new feature to the change log as well? Then we're good to merge. |
Codecov Report
@@ Coverage Diff @@
## devel #1264 +/- ##
==========================================
- Coverage 91.22% 91.21% -0.01%
==========================================
Files 219 221 +2
Lines 23822 23882 +60
==========================================
+ Hits 21731 21784 +53
- Misses 2091 2098 +7
Continue to review full report at Codecov.
|
Thank you again! Good job! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This multi-dimension histogram plot function was requested at the last pyemma workshop after I showed something similar in my presentation. It's nice to have but not very quantitative since histograms are scaled in order to be visible even for many dimensions. It produces graphs like this: