-
-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add check dependencies script #1018
Add check dependencies script #1018
Conversation
PR Summary
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Few comments that still need answers/modifications for
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- The shebang is incorrect.
- The related documentation needs to be added to the README and related Makefile.
- I'm getting errors when running this script:
~/Sites/magento246-p4 bin/check-dependencies
bin/check-dependencies: line 7: declare: -A: invalid option
declare: usage: declare [-afFirtx] [-p] [name[=value] ...]
bin/check-dependencies: line 10: 2.4.7-beta3: syntax error: invalid arithmetic operator (error token is ".4.7-beta3")
bin/check-dependencies: line 11: 2.4.7-beta2: syntax error: invalid arithmetic operator (error token is ".4.7-beta2")
bin/check-dependencies: line 12: 2.4.6-p4: syntax error: invalid arithmetic operator (error token is ".4.6-p4")
bin/check-dependencies: line 13: 2.4.6-p3: syntax error: invalid arithmetic operator (error token is ".4.6-p3")
bin/check-dependencies: line 14: 2.4.6-p2: syntax error: invalid arithmetic operator (error token is ".4.6-p2")
bin/check-dependencies: line 15: 2.4.6-p1: syntax error: invalid arithmetic operator (error token is ".4.6-p1")
bin/check-dependencies: line 16: 2.4.6: syntax error: invalid arithmetic operator (error token is ".4.6")
bin/check-dependencies: line 17: 2.4.5-p5: syntax error: invalid arithmetic operator (error token is ".4.5-p5")
bin/check-dependencies: line 18: 2.4.5-p4: syntax error: invalid arithmetic operator (error token is ".4.5-p4")
bin/check-dependencies: line 19: 2.4.5-p3: syntax error: invalid arithmetic operator (error token is ".4.5-p3")
bin/check-dependencies: line 20: 2.4.5-p2: syntax error: invalid arithmetic operator (error token is ".4.5-p2")
bin/check-dependencies: line 21: 2.4.5-p1: syntax error: invalid arithmetic operator (error token is ".4.5-p1")
bin/check-dependencies: line 22: 2.4.5: syntax error: invalid arithmetic operator (error token is ".4.5")
bin/check-dependencies: line 23: 2.4.4-p6: syntax error: invalid arithmetic operator (error token is ".4.4-p6")
bin/check-dependencies: line 24: 2.4.4-p5: syntax error: invalid arithmetic operator (error token is ".4.4-p5")
bin/check-dependencies: line 25: 2.4.4-p4: syntax error: invalid arithmetic operator (error token is ".4.4-p4")
bin/check-dependencies: line 26: 2.4.4-p3: syntax error: invalid arithmetic operator (error token is ".4.4-p3")
bin/check-dependencies: line 27: 2.4.4-p2: syntax error: invalid arithmetic operator (error token is ".4.4-p2")
bin/check-dependencies: line 28: 2.4.4-p1: syntax error: invalid arithmetic operator (error token is ".4.4-p1")
bin/check-dependencies: line 29: 2.4.4: syntax error: invalid arithmetic operator (error token is ".4.4")
bin/check-dependencies: line 30: 2.4.3-p3: syntax error: invalid arithmetic operator (error token is ".4.3-p3")
bin/check-dependencies: line 31: 2.4.2-p2: syntax error: invalid arithmetic operator (error token is ".4.2-p2")
Enter the Magento 2 version you'd like to check dependencies on:
The problem is that MacOS uses an older version of Bash by default, which does not support associative arrays (declare -A). To fix this, you need to use bash version 4 or higher. In my case, the script works perfectly:
I will fix compatibility with MacOS in the next commit. |
I added compatibility with MacOS in the previous commit, so now it should work on MacOS. Please feel free to check it. |
a5f45e7
to
040b212
Compare
Great, thanks, works as expected! Merging in 👍 |
Script Overview
Introduces a script for the swift and straightforward installation of Magento 2, specifically tailored for beginners. The script provides helpful recommendations for dependencies.
Highlighted Features
Your contributions, feedback, and suggestions are welcome!