Avoid double-quoting fragment in a test #115
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This illustrates the problem by putting non-URI-safe characters in the example schema, which is not strictly necessary. But with these characters, the old test code failed and the new test code passes.
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## main #115 +/- ##
=======================================
Coverage 92.73% 92.73%
=======================================
Files 23 23
Lines 2052 2052
Branches 435 435
=======================================
Hits 1903 1903
Misses 97 97
Partials 52 52 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note: I promise this is not about URI libraries! Or at least not intentionally... I broke this test in a completely unrelated way. and stumbled across this problem.
This illustrates the problem by putting non-URI-safe characters in the example schema, which is not strictly necessary. But with these characters, the old test code failed and the new test code passes.
I'd be happy to change the PR to leave "X" alone and just remove the quoting, I just wanted the problem to be clear and reproduceable.