Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Unit Testing #59

Merged
merged 9 commits into from
Jul 22, 2023
Merged

Add Unit Testing #59

merged 9 commits into from
Jul 22, 2023

Conversation

mvorisek
Copy link
Contributor

@mvorisek mvorisek commented Jul 17, 2023

Tests should not only assert the buid passes, but also the output is exactly what we expect.

The base format of the tests input is markdown with MyST extension. This allows us to test native rst using eval-rst as well as pure AST processing - for future for #55.

When a test input is modified, the GH Actions autocommit the output changes to <current_branch>.changes branch so you can easily fix the expectaions.

@mvorisek mvorisek force-pushed the unit_testing branch 7 times, most recently from 65c0027 to afac64b Compare July 17, 2023 11:27
@mvorisek mvorisek marked this pull request as ready for review July 17, 2023 11:31
.github/workflows/ci.yml Outdated Show resolved Hide resolved
.github/workflows/ci.yml Show resolved Hide resolved
@markstory
Copy link
Owner

markstory commented Jul 19, 2023

The build 'passed' but with errors

Build finished. The HTML pages are in _build/html.
./search.html:20: parser error : Specification mandates value for attribute defer
  <script src="searchindex.js" defer></script>
                                    ^
-:1: parser error : Document is empty

@mvorisek
Copy link
Contributor Author

The build 'passed' but with errors

Build finished. The HTML pages are in _build/html.
./search.html:20: parser error : Specification mandates value for attribute defer
  <script src="searchindex.js" defer></script>
                                    ^
-:1: parser error : Document is empty

It is a passing xmlint warning, I sent sphinx-doc/sphinx#11494 PR to sphinx repo, for now, ignore the warning, once sphinx will release fixed version, the warning will be gone.

@markstory markstory merged commit 70fca3a into markstory:master Jul 22, 2023
@mvorisek mvorisek deleted the unit_testing branch July 22, 2023 08:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants