Porting to use the new mysql::deepmerge function #123
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `mysql_deepmerge` function was flawed and will crash on Puppet version 5.5.7. This changes your code to use the new version of the function, which does not have this flaw. See https://tickets.puppetlabs.com/browse/MODULES-8193 for more details.
|
Btw, you should update your test matrix to match your module's support :) |
|
@binford2k Thanks! I'll leave this open until there's a release of puppetlabs/mysql that contains this change.
Thanks. Fixing CI is planned #108. |
Just FYI: That change has been included since puppetlabs/mysql release 6.0.0 - we are on 7.0.0 with 6.2.0 and 6.1.0 as releases in between (https://forge.puppet.com/puppetlabs/mysql/changelog). |
|
@xTrekStorex Thanks for the clarification! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
mysql_deepmergefunction was flawed and will crash on Puppet version 5.5.7. This changes your code to use the new version of the function, which does not have this flaw. See https://tickets.puppetlabs.com/browse/MODULES-8193 for more details.