Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

data export with x- and y-axis as log scale #345

Closed
celentanos opened this issue Jul 22, 2019 · 8 comments
Closed

data export with x- and y-axis as log scale #345

celentanos opened this issue Jul 22, 2019 · 8 comments
Labels

Comments

@celentanos
Copy link

When I set x- and y-axis as log scale and try export data the program hangs. It seams to be an endless while loop in ExportValuesXOrY ExportXThetaValuesMergedFunctions::periodicLogGraph(...)
function.

@celentanos celentanos changed the title data export with x-axis and y-axis log scale data export with x- and y-axis as log scale Jul 22, 2019
@markummitchell
Copy link
Owner

Hello, I am wondering if you have a sample data file that triggers the problem. Sorry for the slow response

@celentanos
Copy link
Author

https://yadi.sk/d/MPqkjXODey32gw this is the corresponding file.

I only made the changes in Coordinates- and in Export Format Settings (see figures below). Then I tried to export the data in csv format. But the program starts to hang (with 100% CPU load in an one thread) when the two axes are set to log and you click on the export settings.

Screenshot_20190725_132921
Screenshot_20190725_132956

@markummitchell
Copy link
Owner

Thanks. I am able to see the problem. This should be fixed quickly. After testing you can try out the fixed version - about 2 days.

@markummitchell
Copy link
Owner

There is a 64 bit Windows pre-release at https://ci.appveyor.com/project/markummitchell/engauge-digitizer/branch/master/job/tahk5voottucfy38/artifacts. You can extract that file using tools like 7zip or winzip.

@celentanos
Copy link
Author

The program has no hangs more, but the values are not sampled at the specified intervals (see figure below). I have the interval from 0.25 to 2.0 (see figure below).
Screenshot_20190729_122539

Screenshot_20190729_123449

@markummitchell
Copy link
Owner

markummitchell commented Jul 29, 2019

That is working as designed. The step factor in a log plot is multiplicative. So values greater than 1 are needed since the pattern is ymin, ymin * scale, ymin * scale^2, ..., ymax

The Export Settings dialog now disables the Ok button, and does not insert a series of points, when the step is less than one for log scale.

@celentanos
Copy link
Author

Good, I did not know that. The program works as you described. So I will mark this issue as solved. Many thanks :)

@markummitchell
Copy link
Owner

Thanks for the input. This fix will help many people in the future

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants