Updated Python Unit Tests and Added Log Functionality to ParseDig #338
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 5 commits
May 29, 2019 13:46
…or message for log plots since we haven't yet defined the conversion for log plots. Created a test file for DumpGraphAndScreenCoordinates that works with pytest. It creates a .dig file using testDigGenerator.py and then uses Engauge to output the data points from that file. It then parses the .dig file and compares the results, throwing an exception if they don't match. testDigGenerator was a modified version of test.py that now works with four data points and different axis scales.
…vor of the modified version, testDigGenerator.py. Resolved conflicts in ParseDig.py to incorporate the infinite slope code and the code that checks for if it's a log plot
|
These changes came through as part of the second 6/6 pull request |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added some of the basic unit tests in DumpGraphAndScreenCoordinates_test.py (the tests are run when you run pytest). Log functionality in ParseDig.py is limited; I think it should work for four axis points all the time, but it doesn't always work for three axis points if the axis values don't all match up (the graph coordinates need to be in the form (x1, y1), (x1, y2), (x2, y1) (though not in that order necessarily)).