Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplified usage with Docker #4

Closed
qdrop17 opened this issue Aug 23, 2019 · 7 comments · Fixed by #14
Closed

Simplified usage with Docker #4

qdrop17 opened this issue Aug 23, 2019 · 7 comments · Fixed by #14
Labels
enhancement New feature or request

Comments

@qdrop17
Copy link

qdrop17 commented Aug 23, 2019

Hi there.

This is more kind of a feature request then it is an issue. It would be great to have that entire solution in a self-contained Docker image. Both DB and application. This would make the usage far easier.

For instance one could directly use it on Synology-NASes.

Thanks for considering. If I have time, I might try to setup something myself.

@welcome
Copy link

welcome bot commented Aug 23, 2019

Thanks for opening your first issue here! 🎉

@markusressel
Copy link
Owner

Sure thing this would be nice to have. If you get around it open a PR and I will gladly merge it 😊

@markusressel markusressel added the enhancement New feature or request label Aug 24, 2019
@qdrop17
Copy link
Author

qdrop17 commented Aug 29, 2019

ok, I got it running natively - but it was quite difficult. There was no requires.txt but a METADATA-file.

now, image_match fails with the connection to Elasticsearch and I don't know how to fix that (it was using the wrong hostname). After more than 6 invested hours to get it working, I'm quitting now haha!

Your help would be highly appreciated. I would also consider buying you a pack of beers (or couple of coffees) if you provide a Docker container on Docker-Hub that works out of the box.

Anyways - cool stuff you developed here! It seems very useful to me.

@markusressel
Copy link
Owner

Yeah I'm sorry it's so difficult to set up. Part of that is also due to image-match beeing outdated. I will try to getto this on the weekend. Glad you like it! :)

@markusressel
Copy link
Owner

markusressel commented Aug 31, 2019

Hey @qdrop17 , just a little heads up:
I worked the whole day on #5 which will hopefully make it a lot easier to run py-image-dedup inside a container. While doing this I also had some issues with the latest version of elasticsearch that I had installed locally on my dev machine. I have fixed these issues now, so you can give it another shot if you use a recent version of elasticsearch too.

@markusressel
Copy link
Owner

@qdrop17 fyi, I have finished docker support. I still need to write some documentation for it in the README but if you understand how docker works and docker-compose have a look 🤓

@qdrop17
Copy link
Author

qdrop17 commented Oct 4, 2019

@qdrop17 fyi, I have finished docker support. I still need to write some documentation for it in the README but if you understand how docker works and docker-compose have a look 🤓

Very cool, thank you so much! It actually works flawlessly on a generic Ubuntu machine. But it's not working on my DS718+ NAS. Maybe a broken Docker installation or incompatibilities with the CPU.

The py-image-dedup container is not writing any logs on this NAS.

Thank you very much for your efforts anyway!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants