Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement minSR from arXiv:2302.01941. #39

Merged
merged 6 commits into from
Jun 10, 2023
Merged

Implement minSR from arXiv:2302.01941. #39

merged 6 commits into from
Jun 10, 2023

Conversation

RehMoritz
Copy link
Collaborator

Implementation of the minSR algorithm that was successfully tested on the 6x6 J1-J2.
We would however need to adapt the storage of some of the metadata (i.e. tdvp error and similar) that requires computation of the S-matrix.

@RehMoritz RehMoritz requested a review from markusschmitt April 6, 2023 17:32
@markusschmitt
Copy link
Owner

Implementation of the minSR algorithm that was successfully tested on the 6x6 J1-J2. We would however need to adapt the storage of some of the metadata (i.e. tdvp error and similar) that requires computation of the S-matrix.

I would suggest to separate the minSR from the TDVP class and instead have an own class for it. This should then just return additional info that is immediately available.

Can we also add a test that compares for a small system ground state energies obtained by SR and by minSR?

@markusschmitt
Copy link
Owner

Implementation of the minSR algorithm that was successfully tested on the 6x6 J1-J2. We would however need to adapt the storage of some of the metadata (i.e. tdvp error and similar) that requires computation of the S-matrix.

I would suggest to separate the minSR from the TDVP class and instead have an own class for it. This should then just return additional info that is immediately available.

Can we also add a test that compares for a small system ground state energies obtained by SR and by minSR?

I implemented these suggestions.

@markusschmitt markusschmitt merged commit 2a14b4e into master Jun 10, 2023
@markusschmitt markusschmitt deleted the minSR branch June 10, 2023 17:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants