Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
RNN with complex parameters could not be created. To reproduce:
gives the output
I fixed the wrong arguments passed to
cplx_variance_scaling()
. Also, in the case of RNN1DGeneral(), theself.dtype
argument was not passed toRNNCellStack()
which caused mixing of datatypes (complex and float). I also added tests for RNN with complex parameters, but I am sure it is not a good practice to compare the output of the RNN with the fixed value. But the test allows one to see if the RNN1DGeneral and RNN2DGeneral at least compile.