Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add logic to support nested Svgs #23

Merged
merged 3 commits into from
Apr 8, 2021
Merged

Add logic to support nested Svgs #23

merged 3 commits into from
Apr 8, 2021

Conversation

marlenecota
Copy link
Owner

  • Move the following out of RenderableView and into a new interface, IRenderable, that both RenderableView and SvgView implement:
    • SvgParent
    • Geometry
    • Render()
    • UpdateProperties()
    • MergeProperties()
    • SaveDefinition()
    • Unload()
  • Switch GroupView's Children and SvgView's Templates from RenderableViews to IRenderables.
  • Fix SvgRoot logic to check if an SvgView has an SvgParent as it is null in the root Svg element.
  • If SvgView is inhering props from a parent, it passes those through to its Group.
  • When setting an SvgView's SvgParent, we revoke event handlers and null out the canvas.

@marlenecota marlenecota merged commit 0dacc8b into windows Apr 8, 2021
@marlenecota marlenecota deleted the nested-svg branch April 8, 2021 05:48
@marlenecota marlenecota linked an issue Apr 8, 2021 that may be closed by this pull request
marlenecota added a commit that referenced this pull request Aug 17, 2021
* Move methods from RenderableView to IRenderable to share with SvgView

* Add logic for nested Svgs

* Remove CreateGeometry() from SvgView
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Nested Svg elements not working
1 participant