Fix prop inheritance of reusable elements and CanvasControl memory leak. #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
marlenecota
commented
Apr 3, 2021
marlenecota
commented
- Prop propagation in reusable elements:
- Use now pushes its props to its children (as long as the prop is not set on the child).
- It then restores the child's original props after render.
- CanvasControl memory leak:
- https://microsoft.github.io/Win2D/WinUI2/html/RefCycles.htm
- Have to listen to the Panel's Unloaded event and explicitly remove the canvas from the VisualTree in order for resources to be freed.
marlenecota
added a commit
that referenced
this pull request
Aug 17, 2021
…ak. (#5) * Fix prop propagation of UseView * Symbol: Fix prop inheritance. SvgView: Add Page Unload handler
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.