[Documentation] README.md suggests "npm install --save-dev react-admin" instead of "npm install react-admin"

[ajhool]

This is a minor documentation issue so I am ignoring the standard bug report for brevity's sake. Happy to edit to the full format if need be!

The README.md installation section:

Installation
React-admin is available from npm. You can install it (and its required dependencies) using:

npm install --save-dev react-admin

react-admin is a runtime package, so why is --save-dev suggested?

Suggested update: change README.md to use npm install react-admin or yarn add react-admin instead of npm install --save-dev react-admin

[phacks]

I was asking myself the exact same question. Did a little bit of digging and it looks like the --save-dev dates back to the early days of admin-on-rest, 2+ years ago.

Maybe @fzaninotto knows the reason?

[fzaninotto]

It dates from my confusion about how React apps are built: since we use webpack at build time, and webpack creates a bundle with all the required dependencies, I thought there were no need for react or react-admin to actually run the app. But dependencies for SPAs aren't about running the app, but about building the app.

So yes, you're right, we can remove --save-dev. Would you like to open a PR?

[phacks]

@fzaninotto thanks for the explanation! I wouldn’t mind opening a PR, but maybe @ajhool might want to give it a go since they spotted this in the first place. What do you think @ajhool?

[ajhool]

Thanks for digging into this, I'm happy to!

…

On Wed, Nov 21, 2018, 7:59 AM Nicolas Goutay ***@***.***> wrote: @fzaninotto <https://github.com/fzaninotto> thanks for the explanation! I wouldn’t mind opening a PR, but maybe @ajhool <https://github.com/ajhool> might want to give it a go since they spotted this in the first place. What do you think @ajhool <https://github.com/ajhool>? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#2420 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AKTSf4_HEovkEH4f65yMcX7KxsKMH42oks5uxU5IgaJpZM4XYS9k> .

[phacks]

@ajhool did you have time to have a look at updating the docs?

[ajhool]

Thanks for reminder, see below :)
#2574

[fzaninotto]

fixed by #2574