Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

yarn prettier different formatting #2724

Closed
JacquesBonet opened this issue Jan 3, 2019 · 1 comment · Fixed by #2839
Closed

yarn prettier different formatting #2724

JacquesBonet opened this issue Jan 3, 2019 · 1 comment · Fixed by #2839
Assignees
@fzaninotto
Labels
bug

Comments

@JacquesBonet
Copy link
Contributor

JacquesBonet commented Jan 3, 2019 •
edited
Loading

When I execute the command yarn prettier I have 590 files reformatted.

That seem not correct: I expect to have same formating than files in the repo.
This is also problematic when the ide reformat the sources code according the prettier rules, prettier rules not matching with js files.

Jacques
@fzaninotto fzaninotto added the bug label Jan 4, 2019
@fzaninotto
Copy link
Member

Bug confirmed

@lucas2595 lucas2595 mentioned this issue Jan 11, 2019
Merged
fzaninotto added a commit that referenced this issue Jan 31, 2019
@fzaninotto
Fix prettier command
94f83c5 
Closes #2724
@fzaninotto fzaninotto mentioned this issue Jan 31, 2019
Merged
@fzaninotto fzaninotto self-assigned this Jan 31, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@fzaninotto fzaninotto

Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[RFR] Fix prettier command marmelab/react-admin
2 participants
@fzaninotto @JacquesBonet