Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename appLayout to layout in <Admin> #2918

Closed
fzaninotto opened this issue Feb 22, 2019 · 3 comments
Closed

Rename appLayout to layout in <Admin> #2918

fzaninotto opened this issue Feb 22, 2019 · 3 comments
Labels
breaking change

Comments

@fzaninotto
Copy link
Member

The current prop name for the layout in <Admin> isn't intuitive.
@yuriydobryanskyyempeek
Copy link
Contributor

I think you can add an "alias" prop - so both are accepted. And mark appLayout as deprecated till next major version bump.

@Kmaschta
Copy link
Contributor

Kmaschta commented Mar 1, 2019

You're right! PR are welcome :)

@kopax kopax mentioned this issue Mar 25, 2019
Merged
fzaninotto pushed a commit that referenced this issue May 19, 2019
@kopax @fzaninotto
feat(layout): added layout (#3055)
9cfe0a4 
feat(layout): Added prop layout and added deprecation warning to
appLayout

BREAKING CHANGE: the prop appLayout will be removed in favor of layout

Fix #2918
@fzaninotto
Copy link
Member Author

fixed by #3055

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
breaking change
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@fzaninotto @Kmaschta @yuriydobryanskyyempeek