Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[v3] SimpleForm / TabbedForm are missing PropTypes #3969

Closed
WiXSL opened this issue Nov 11, 2019 · 1 comment
Closed

[v3] SimpleForm / TabbedForm are missing PropTypes #3969

WiXSL opened this issue Nov 11, 2019 · 1 comment
Labels
enhancement good first issue

Comments

@WiXSL
Copy link
Contributor

WiXSL commented Nov 11, 2019

SimpleForm and TabbedForm Components don't have propTypes defined.
SimpleFormView and TabbedFormView have them instead and is killing my intellisense ;-).
I'll add them myself, but i'm not sure which ones to include.
DanudeSandstorm added a commit to DanudeSandstorm/react-admin that referenced this issue Nov 12, 2019
@DanudeSandstorm
Closes marmelab#3969
fc4d9a8
@DanudeSandstorm DanudeSandstorm mentioned this issue Nov 13, 2019
Closed
@WiXSL WiXSL mentioned this issue Nov 18, 2019
Merged
@fzaninotto
Copy link
Member

Fixed by #3996

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement good first issue
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@fzaninotto @Kmaschta @WiXSL