Fix create-react-admin CLI to generate valid react-admin v5 apps
#10131
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fzaninotto
requested changes
Aug 6, 2024
| "module": "ESNext", | ||
| "skipLibCheck": true, | ||
|
|
||
| /* Bundler mode */ |
There was a problem hiding this comment.
But it's valid tsconfig though
| @@ -1,5 +1,6 @@ | |||
| { | |||
| "private": true, | |||
| "type": "module", | |||
There was a problem hiding this comment.
that's a strong choice. If it forces users to use cjs instead of js, I'm -1 for it.
There was a problem hiding this comment.
This is the default for vite templates with TS/React and thanks to the TS config it just work (moduleResolution=Bundler)
| @@ -4,9 +4,6 @@ import react from '@vitejs/plugin-react'; | |||
| // https://vitejs.dev/config/ | |||
| export default defineConfig({ | |||
| plugins: [react()], | |||
| define: { | |||
There was a problem hiding this comment.
Because it's unnecessary
| "skipLibCheck": true, | ||
| "types": ["vitest/globals"], | ||
|
|
||
| /* Bundler mode */ |
| @@ -5,9 +5,6 @@ import react from '@vitejs/plugin-react'; | |||
| // https://vitejs.dev/config/ | |||
| export default defineConfig({ | |||
| plugins: [react()], | |||
| define: { | |||
fzaninotto
approved these changes
Aug 6, 2024
fzaninotto
changed the title
create-react-admin CLI to generate valid react-admin v5 apps
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
create-react-admintests fail onmasterSolution
create-react-admindependenciesHow To Test
In react-admin repository clone directory:
make build-create-react-admin installIn a directory one level above the react-admin repository clone:
./node_modules/.bin/create-react-admin myadmin --data-provider ra-data-fakerest --auth-provider local-auth-provider --install npmcd myadminnpm run test