Can set order value for SET_SORT action #2855
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
djhi
requested changes
Feb 6, 2019
packages/ra-core/src/reducer/admin/resource/list/queryReducer.spec.js
Outdated
Show resolved
Hide resolved
packages/ra-core/src/reducer/admin/resource/list/queryReducer.spec.js
Outdated
Show resolved
Hide resolved
|
By the way, as this is technically a new feature, would you mind targeting the |
|
@djhi of course. I am going to change the target and the titles. thanks for reviewing |
The previous import location threw an error for me as it couldn't be found.
Update Unit Testing documentation
djhi
approved these changes
Feb 13, 2019
|
we need to rebase |
|
Sorry about that @frankPairs, we are migrating to TS |
…lter instead of a greedy regular expression.
|
@djhi @fzaninotto it's ok, i will update the PR using TS |
[RFR] Finalize ra-core i18n Migration to TypeScript
…nference [RFR] Migrate inference code to TypeScript
[RFR] Migrate ra-core form code to TypeScript
- [x] Fields - [ ] Inputs - [ ] Views
…er-get-many-patch Fix GET_MANY in ra-data-json-server data provider returns too many results
Corrected prop types for ArrayInput
…ontrollers [RFR] Migrate ra-core controllers to TypeScript
Fix typo in tutorial.md
add a note about CloneButton component to docs
Fix position of choices container when input element moves to another location
Fix error thrown by ChipInput component generated by AutocompleteArrayInput
|
@djhi @fzaninotto sorry I did a rebase. I am going to create another PR from the branch with this changes, I think that it is simpler. thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi!
This PR is related to the issue #2736.
Now we can pass a order value. This order value will change the state only when sort value is different than the previousState.sort.
It allows us to define a default order value every time sort value is new.
Regards!