Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RFR] Export and document TabbedShowLayoutTabs #2929

Merged

Conversation

lucas2595
Copy link
Contributor

PR to export and document the component created in #2740.

@lucas2595 lucas2595 marked this pull request as ready for review February 25, 2019 14:22
@lucas2595 lucas2595 changed the title Export and document TabbedShowLayoutTabs [RFR] Export and document TabbedShowLayoutTabs Feb 25, 2019
@djhi djhi added this to the 2.7.3 milestone Feb 25, 2019
docs/Show.md Outdated
const ScrollableTabbedShowLayout = props => (
<Show{...props}>
<TabbedShowLayout tabs={<TabbedShowLayoutTabs scrollable={true}/>}>
<Tab label="Tab Component 1">
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As the TabbedShowLayout usage is already detailed in the previous section, maybe we can even remove all <Tab> here

Removing them as they've already been mentioned previously.
@djhi
Copy link
Collaborator

djhi commented Feb 25, 2019

Thanks!

@djhi djhi merged commit e6d9714 into marmelab:master Feb 25, 2019
@lucas2595
Copy link
Contributor Author

No problem!

@lucas2595 lucas2595 deleted the export-and-document-TabbedShowLayoutTabs branch February 25, 2019 17:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants