[RFR] Pre-commit hooks #3306
Merged
[RFR] Pre-commit hooks #3306
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can you rebase? |
fzaninotto
requested changes
Jun 7, 2019
added 2 commits
June 8, 2019 10:33
fzaninotto
requested changes
Jun 8, 2019
Makefile
Outdated
| @@ -117,7 +117,8 @@ test-unit: ## launch unit tests | |||
| fi | |||
|
|
|||
| test-unit-watch: ## launch unit tests and watch for changes | |||
| yarn -s test-unit --watch | |||
| echo "Running unit tests in CI..."; \ | |||
fzaninotto
approved these changes
Jun 8, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow #3304
We currently refuse some pull requests because of linting/formatting issues far too often.
This PR leverage
huskyandlint-stagedto run prettier and tslint on every modified files. Besides, it also run the unit tests related to those files, and only those, ensuring a fast feedback loop without having to wait for a Travis build only to realize you forgot to run the tests for your changes. Thanks Jest!