[RFR] Refactor validators to not return translated errors #3339
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I noticed that we don't handle errors and helperText the same way for all inputs. Some will display the error instead of the helperText, some will display both. I think it would be better to handle this in a consistant way by introducing an |
djhi
force-pushed
the
refactor-validators
branch
from
87baf9b to
5e7fa46
Compare
djhi
force-pushed
the
refactor-validators
branch
from
5e7fa46 to
9b02c03
Compare
djhi
changed the title
fzaninotto
requested changes
Jun 19, 2019
packages/ra-ui-materialui/src/input/AutocompleteArrayInput.spec.js
Outdated
Show resolved
Hide resolved
fzaninotto
requested changes
Jun 20, 2019
| }); | ||
|
|
||
| describe('error message', () => { | ||
| it('should not be displayed if field is pristine', () => { | ||
| const { container } = render( |
djhi
commented
Jun 20, 2019
| this.props.input.onBlur(value); | ||
| this.setState({ value }); | ||
| }; | ||
| useEffect(() => { |
There was a problem hiding this comment.
Obviously a code smell. This is the implementation of the previous componentWillReceiveProps. Hopefully this will not be needed after migrating to final-forms
fzaninotto
requested changes
Jun 25, 2019
fzaninotto
reviewed
Jun 25, 2019
fzaninotto
changed the title
fzaninotto
approved these changes
Jun 25, 2019
|
Thanks! |
This was referenced Jun 25, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the first step to migrate from redux-form to
final-form. Indeed,react-final-formvalidators won't receive props anymore, so our current third argument containing thetranslatefunction will always be empty.This PR refactor the validators to return either a string which will be translated or an object with
messageandargsproperties.I also introduced an unstyled
ValidationErrorcomponent which knows how to translate those errors. As it returns the resulting string inside a React Fragment, it can be defined inra-coreand used in any UI library.Finally, I updated the official inputs to use this
ValidationError. In the process, I have migrated their tests fromenzymetoreact-testing-libraryand ensured all inputs support thehelperTextprop.ValidationErrorcomponentInputHelperTextcomponent