Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RFR] Use hooks on demo (last PR) #3345

Merged
merged 2 commits into from
Jul 14, 2019
Merged

[RFR] Use hooks on demo (last PR) #3345

merged 2 commits into from
Jul 14, 2019

Conversation

zyhou
Copy link
Contributor

@zyhou zyhou commented Jun 19, 2019

  • Use makeStyles on demo
  • Use function component
  • fix } render in ReferenceManyField.js

Review with "Hide whitespace changes" options in Github

@zyhou zyhou force-pushed the use-hooks-on-demo branch from 3ba4025 to f2ca36a Compare June 19, 2019 13:04
@zyhou zyhou added this to the 3.0.0 milestone Jun 19, 2019
@zyhou zyhou changed the title [RFR] Use hooks on demo (last PR) [WIP] Use hooks on demo (last PR) Jun 19, 2019
@zyhou zyhou changed the title [WIP] Use hooks on demo (last PR) [RFR] Use hooks on demo (last PR) Jun 19, 2019
@zyhou zyhou force-pushed the use-hooks-on-demo branch 2 times, most recently from 3758c94 to 62a35e0 Compare June 19, 2019 15:08
examples/demo/src/layout/Login.js Show resolved Hide resolved
examples/demo/src/orders/Basket.js Outdated Show resolved Hide resolved
examples/demo/src/orders/Basket.js Outdated Show resolved Hide resolved
examples/demo/src/orders/Basket.js Show resolved Hide resolved
examples/demo/src/reviews/BulkAcceptButton.js Outdated Show resolved Hide resolved
</div>
useEffect(() => {
dispatch(
crudGetList(
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can use the useGetList hook instead. that'll remove most of the code. Up to you!

@fzaninotto
Copy link
Member

bump

@zyhou zyhou force-pushed the use-hooks-on-demo branch 2 times, most recently from 8090f2a to 1ecdb4e Compare July 12, 2019 15:33
@zyhou zyhou force-pushed the use-hooks-on-demo branch from 1ecdb4e to 9dc088a Compare July 12, 2019 15:53
@zyhou zyhou requested a review from fzaninotto July 12, 2019 15:53
@fzaninotto fzaninotto merged commit 3ec6799 into next Jul 14, 2019
@fzaninotto
Copy link
Member

Thanks!

@fzaninotto fzaninotto deleted the use-hooks-on-demo branch July 14, 2019 11:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants