Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RFR] Fix theme.spacing warning #3492

Merged
merged 1 commit into from
Aug 7, 2019
Merged

[RFR] Fix theme.spacing warning #3492

merged 1 commit into from
Aug 7, 2019

Conversation

Luwangel
Copy link
Contributor

@Luwangel Luwangel commented Aug 7, 2019

Fix the remaining warning with the material UI v4 migration.

Warning: Material-UI: theme.spacing.unit usage has been deprecated.
It will be removed in v5.
You can replace theme.spacing.unit * y with theme.spacing(y).

Todo

  • Fix warning in Datagrid

@Kmaschta Kmaschta added this to the 3.0.0 milestone Aug 7, 2019
@djhi djhi merged commit 6e26348 into next Aug 7, 2019
@Luwangel Luwangel deleted the fix-warnings branch August 7, 2019 18:14
@Earlo
Copy link

Earlo commented Aug 12, 2019

Why did this go to 3.0.0 instead of 2.9.6.?

@Luwangel
Copy link
Contributor Author

@Earlo react-admin v3 will be the first release compatible with material-ui v3, which introduces the new theme.spacing() api. That's why I fixed the warning on the next (3.0) branch, and not on master (2.9).

You can check the following upgrade guide from material-ui to see all the breaking changes material-ui/migration-v3.

@LaszloDev
Copy link

Still seeing this error on react-admin@3.0.2. Any updates regards this?

@fzaninotto
Copy link
Member

@LaszloDev Can you isolate the code that triggers that warning?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants