-
-
Notifications
You must be signed in to change notification settings - Fork 5.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[RFR] Migrate RadioButtonGroupInput to use useInput #3538
Conversation
expect(input2.type).toBe('radio'); | ||
expect(input2.name).toBe('foo'); | ||
expect(input2.name).toBe('type'); | ||
expect(input2.checked).toBeFalsy(); | ||
}); | ||
|
||
it('should use the input parameter value as the initial input value', () => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you've completely changed the tes implementation, so the test title no longer corresponds to the implementation.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't really get that comment. initialValues
provides the initial input value and we check that is indeed applied to the underlying input
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we no longer use the 'input parameter value', as the test description says
packages/ra-ui-materialui/src/input/RadioButtonGroupInput.spec.js
Outdated
Show resolved
Hide resolved
Co-Authored-By: Francois Zaninotto <francois@marmelab.com>
bcef715
to
0f7ba10
Compare
No description provided.