Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add an optional Polyglot.js-Options prop #3662

Closed

Conversation

Charioteer
Copy link

I was in the need of using Polyglot.js' onMissingKey-callback to send missing translations automatically to my API. To do so i have added an optional polyglotOptions-prop in CoreAdmin to pass an additional settings object to use Polyglot's full features.

@fzaninotto
Copy link
Member

This cannot be PRed against master, as it is a new feature, so please target next.

Also, we're doing our best to avoid adding more props to <Admin>. I would agree to support an options prop in the TranslationProvider component, but in order to use it, you'll have to use the Custom App approach, unless you find a more elegant way that does not involve adding a new prop to Admin.

@fzaninotto
Copy link
Member

Superseded by #3685

@fzaninotto fzaninotto closed this Sep 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants