Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Content-Type header only for non GET requests. #3743

Merged
merged 3 commits into from
Oct 3, 2019
Merged

Add Content-Type header only for non GET requests. #3743

merged 3 commits into from
Oct 3, 2019

Conversation

clement-escolano
Copy link
Contributor

Fixes #3687

djhi
djhi requested changes Sep 27, 2019
View reviewed changes
Copy link
Collaborator

@djhi djhi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would you mind adding a test for it ?

@clement-escolano
Copy link
Contributor Author

Would you mind adding a test for it ?

The fetchJson is actually not tested at all and involve a lot of logic (network, promises, etc). I can add some tests for the use case of the PR but I don't feel comfortable with creating all the boilerplate to test fetchJson method.
What do you think?

@djhi
Copy link
Collaborator

djhi commented Sep 27, 2019

A test just for the use case of the PR would be enough :) Thanks!

djhi
djhi approved these changes Sep 27, 2019
View reviewed changes
Copy link
Collaborator

@djhi djhi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@djhi djhi added this to the 2.9.7 milestone Sep 27, 2019
@fzaninotto fzaninotto merged commit f940e4c into marmelab:master Oct 3, 2019
@fzaninotto
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fzaninotto fzaninotto fzaninotto approved these changes

@djhi djhi djhi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2.9.7
Development

Successfully merging this pull request may close these issues.

Issue with the Content-Type header for GET requests
3 participants
@clement-escolano @djhi @fzaninotto