-
-
Notifications
You must be signed in to change notification settings - Fork 5.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[RFR] move stateful to peer dependencies and devDependencies within modules, add them to react-admin as dependencies #3763
Merged
fzaninotto
merged 8 commits into
marmelab:next
from
kopax:improve-peer-dependencies-1683
Oct 4, 2019
Merged
[RFR] move stateful to peer dependencies and devDependencies within modules, add them to react-admin as dependencies #3763
fzaninotto
merged 8 commits into
marmelab:next
from
kopax:improve-peer-dependencies-1683
Oct 4, 2019
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ies and devDependencies
kopax
changed the title
[WIP] move stateful peer dependencies and devDependencies
[WIP] move stateful to peer dependencies and devDependencies within modules, add them to react-admin as dependencies
Oct 2, 2019
kopax
changed the title
[WIP] move stateful to peer dependencies and devDependencies within modules, add them to react-admin as dependencies
[RFR] move stateful to peer dependencies and devDependencies within modules, add them to react-admin as dependencies
Oct 2, 2019
I've fixed the bug in |
Now e2e tests seem to fail for a valid reason, please check. |
Is there a way to prevent e2e test from starting/closing so fast, so I can trace and debug? |
Just call |
fzaninotto
requested changes
Oct 3, 2019
unit and e2e now pass. |
fzaninotto
reviewed
Oct 3, 2019
fzaninotto
approved these changes
Oct 3, 2019
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
FYI: I have created a public gist with the list of all known peer dependencies in npm, feel free to add some.