Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[RFR] move stateful to peer dependencies and devDependencies within modules, add them to react-admin as dependencies #3763

Merged
merged 8 commits into from
Oct 4, 2019
Merged

[RFR] move stateful to peer dependencies and devDependencies within modules, add them to react-admin as dependencies #3763

merged 8 commits into from
Oct 4, 2019

Conversation

kopax
Copy link
Contributor

@kopax kopax commented Oct 2, 2019 •
edited
Loading

FYI: I have created a public gist with the list of all known peer dependencies in npm, feel free to add some.

@kopax kopax mentioned this pull request Oct 2, 2019
Closed
@fzaninotto fzaninotto added this to the 3.0.0 milestone Oct 2, 2019
@kopax kopax changed the title [WIP] move stateful peer dependencies and devDependencies [WIP] move stateful to peer dependencies and devDependencies within modules, add them to react-admin as dependencies Oct 2, 2019
@kopax kopax changed the title [WIP] move stateful to peer dependencies and devDependencies within modules, add them to react-admin as dependencies [RFR] move stateful to peer dependencies and devDependencies within modules, add them to react-admin as dependencies Oct 2, 2019
@fzaninotto
Copy link
Member

I've fixed the bug in next in b5828cd and relaunched the build of your PR.

@fzaninotto
Copy link
Member

Now e2e tests seem to fail for a valid reason, please check.

@kopax
Copy link
Contributor Author

kopax commented Oct 3, 2019

Now e2e tests seem to fail for a valid reason, please check.

Is there a way to prevent e2e test from starting/closing so fast, so I can trace and debug?

@fzaninotto
Copy link
Member

Just call make run and test manually.

fzaninotto
fzaninotto requested changes Oct 3, 2019
View reviewed changes
packages/ra-tree-ui-materialui/package.json Outdated Show resolved Hide resolved
yarn.lock Outdated Show resolved Hide resolved
@kopax
Copy link
Contributor Author

kopax commented Oct 3, 2019

unit and e2e now pass.

@kopax kopax requested a review from fzaninotto October 3, 2019 09:55
@fzaninotto fzaninotto mentioned this pull request Oct 3, 2019
Closed
40 tasks
fzaninotto
fzaninotto reviewed Oct 3, 2019
View reviewed changes
packages/ra-tree-ui-materialui/package.json Outdated Show resolved Hide resolved
yarn.lock Outdated Show resolved Hide resolved
@kopax kopax requested a review from fzaninotto October 3, 2019 14:54
@fzaninotto fzaninotto merged commit de85301 into marmelab:next Oct 4, 2019
@fzaninotto
Copy link
Member

Thanks!

@kopax kopax deleted the improve-peer-dependencies-1683 branch October 4, 2019 17:59
@kopax kopax restored the improve-peer-dependencies-1683 branch October 4, 2019 17:59
@kopax kopax deleted the improve-peer-dependencies-1683 branch October 4, 2019 17:59
@kopax kopax mentioned this pull request Oct 5, 2019
Closed
@fzaninotto fzaninotto mentioned this pull request Oct 15, 2019
Closed
@zyhou zyhou mentioned this pull request Oct 21, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fzaninotto fzaninotto fzaninotto approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
3.0.0
Development

Successfully merging this pull request may close these issues.
2 participants
@kopax @fzaninotto