-
-
Notifications
You must be signed in to change notification settings - Fork 5.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[RFR] Added isRowSelectable function prop to Datagrid component. #3964
[RFR] Added isRowSelectable function prop to Datagrid component. #3964
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for working on this :) We'll have to measure the performance impact though.
I'm open to suggestions. |
… selection checkbox only for rows that meet some criteria.
…prop to DatagridRow.
d4b3241
to
1849c33
Compare
…ad of always using a function.
@djhi did you have time to see this? |
No but I have some time today so I will :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks pretty good 👍
Thanks! |
DatagridRow
components of a<Datagrid/>
will show a checkbox ifisRowSelectable
prop returns true.Solves the select all problem described here: #3470 (comment).