Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sanitize translate props injected by the controller components inside views #4250

Merged
merged 1 commit into from
Jan 6, 2020
Merged

Sanitize translate props injected by the controller components inside views #4250

merged 1 commit into from
Jan 6, 2020

Conversation

djhi
Copy link
Collaborator

@djhi djhi commented Jan 6, 2020

Fixes #4207

@djhi djhi added this to the 3.1.2 milestone Jan 6, 2020
@djhi djhi added the RFR Ready For Review label Jan 6, 2020
@fzaninotto
Copy link
Member

the translate prop used to be injected in 2.x, and we didn't warn that it was removed in the 3.0 Upgrade guide. So this is a BC break for people using that injected translate in their 2.X components...

@djhi
Copy link
Collaborator Author

djhi commented Jan 6, 2020

I know, but our controllers still inject it, that's why I did not remove it, just sanitized it out of our views.

fzaninotto
fzaninotto approved these changes Jan 6, 2020
View reviewed changes
Copy link
Member

@fzaninotto fzaninotto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Disregard my comment, we're not passing that prop down, just to a div.

@fzaninotto fzaninotto merged commit 55ccee2 into master Jan 6, 2020
@fzaninotto fzaninotto deleted the fix-translate-props-injected-in-views branch January 6, 2020 15:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fzaninotto fzaninotto fzaninotto approved these changes

Assignees
No one assigned
Labels
RFR Ready For Review
Projects
None yet
Milestone
3.1.2
Development

Successfully merging this pull request may close these issues.

Invalid value for prop translate on <div> tag.
2 participants
@djhi @fzaninotto