Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[RFR] Add color prop to AppBar #4479

Merged
merged 11 commits into from
Mar 10, 2020
Merged

[RFR] Add color prop to AppBar #4479

merged 11 commits into from
Mar 10, 2020

Conversation

WiXSL
Copy link
Contributor

@WiXSL WiXSL commented Mar 5, 2020 •
edited
Loading

Fixes #4396

@WiXSL WiXSL changed the base branch from next to master March 5, 2020 20:59
@WiXSL WiXSL changed the title Add color prop to AppBar Add color prop to AppBar [RFR] Mar 5, 2020
@WiXSL WiXSL changed the title Add color prop to AppBar [RFR] Add color prop to AppBar Mar 5, 2020
@WiXSL WiXSL changed the title Add color prop to AppBar [RFR] Add color prop to AppBar Mar 5, 2020
fzaninotto
fzaninotto requested changes Mar 6, 2020
View reviewed changes
Copy link
Member

@fzaninotto fzaninotto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! As it's a new feature, please PR against next rather than master. Also, you should document that new prop in jsDoc and in the theming documentation.

@WiXSL WiXSL changed the base branch from master to next March 6, 2020 14:04
@WiXSL WiXSL requested a review from fzaninotto March 6, 2020 14:04
djhi
djhi requested changes Mar 9, 2020
View reviewed changes
Copy link
Collaborator

@djhi djhi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

packages/ra-ui-materialui/src/layout/AppBar.js Outdated Show resolved Hide resolved
packages/ra-ui-materialui/src/layout/AppBar.js Outdated Show resolved Hide resolved
fzaninotto
fzaninotto requested changes Mar 9, 2020
View reviewed changes
packages/ra-ui-materialui/src/layout/AppBar.js Outdated Show resolved Hide resolved
packages/ra-ui-materialui/src/layout/AppBar.js Outdated Show resolved Hide resolved
packages/ra-ui-materialui/src/layout/AppBar.js Outdated Show resolved Hide resolved
packages/ra-ui-materialui/src/layout/AppBar.js Outdated Show resolved Hide resolved
@WiXSL WiXSL requested review from djhi and fzaninotto March 9, 2020 17:15
@fzaninotto fzaninotto merged commit a275f15 into marmelab:next Mar 10, 2020
@fzaninotto
Copy link
Member

Thanks!

@fzaninotto fzaninotto added this to the 3.4.0 milestone Mar 10, 2020
@WiXSL WiXSL deleted the add-color-prop-appbar branch March 10, 2020 14:21
@WiXSL WiXSL restored the add-color-prop-appbar branch March 10, 2020 14:22
@WiXSL WiXSL deleted the add-color-prop-appbar branch March 10, 2020 14:22
@fzaninotto fzaninotto mentioned this pull request Mar 19, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fzaninotto fzaninotto fzaninotto approved these changes

@djhi djhi Awaiting requested review from djhi

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
3.4.0
Development

Successfully merging this pull request may close these issues.

AppBar should not use secondary color
3 participants
@WiXSL @fzaninotto @djhi