Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix ReferenceInput when using an object literal as filter prop #4784

Merged
merged 1 commit into from
May 7, 2020
Merged

Fix ReferenceInput when using an object literal as filter prop #4784

merged 1 commit into from
May 7, 2020

Conversation

fzaninotto
Copy link
Member

@fzaninotto fzaninotto commented May 7, 2020 •
edited
Loading

Supersedes #4688

@fzaninotto fzaninotto added the RFR Ready For Review label May 7, 2020
@fzaninotto fzaninotto mentioned this pull request May 7, 2020
Closed
@djhi djhi added this to the 3.5.1 milestone May 7, 2020
@fancyaction
Copy link
Contributor

I've been finding myself using // eslint-disable-line react-hooks/exhaustive-deps more than I like. Not sure where to post about this, but I've been finding lately that RA components are receiving new Material UI classname every render, trigging function component update via that prop change.

Anyway, this looks like a good solution and one we've been waiting for so thanks!

@fzaninotto
Copy link
Member Author

@fancyaction The updated class name is a bug, please open a GitHub issue with a reproducible example.

@fzaninotto fzaninotto merged commit 626356a into master May 7, 2020
@fzaninotto fzaninotto deleted the fix-reference-input-filter-prop branch May 7, 2020 16:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@djhi djhi djhi approved these changes

Assignees
No one assigned
Labels
RFR Ready For Review
Projects
None yet
Milestone
3.5.1
Development

Successfully merging this pull request may close these issues.
3 participants
@fzaninotto @fancyaction @djhi