Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename class PhoneNumberKit to PhoneNumberUtility #798

Merged
merged 11 commits into from
Aug 20, 2024

Conversation

HeEAaD
Copy link
Contributor

@HeEAaD HeEAaD commented Aug 20, 2024

Fixes #755 .

This renames the class PhoneNumberKit to PhoneNumberUtility to resolve the issue described in #755 .

This is a breaking API change, which probably requires a major version bump. See how the sample project needed to be adapted: examples/PhoneBook/Sample/ViewController.swift

Testing Steps:

  • build an artifact (xcframework or .framework) with BUILD_LIBRARY_FOR_DISTRIBUTION=YES
  • Import the artifact into another project
  • make sure Xcode is not reporting errors like this anymore 'PhoneNumber' is not a member type of class 'PhoneNumberKit.PhoneNumberKit'

@bguidolim bguidolim merged commit 3704f7b into marmelroy:master Aug 20, 2024
3 checks passed
@HeEAaD HeEAaD deleted the rename-PhoneNumberKit-class branch August 20, 2024 13:48
mergify bot referenced this pull request in cgrindel/rules_swift_package_manager Sep 21, 2024
This PR contains the following updates:

| Package | Update | Change |
|---|---|---|
|
[marmelroy/PhoneNumberKit](https://github.com/marmelroy/PhoneNumberKit)
| major | `from: "3.8.0"` -> `from: "4.0.0"` |

---

### Release Notes

<details>
<summary>marmelroy/PhoneNumberKit (marmelroy/PhoneNumberKit)</summary>

###
[`v4.0.0`](https://github.com/marmelroy/PhoneNumberKit/releases/tag/4.0.0)

[Compare
Source](https://github.com/marmelroy/PhoneNumberKit/compare/3.8.0...4.0.0)

#### What's Changed

- Updated metadata to version metadata/8.13.43 by
[@&#8203;github-actions](https://github.com/github-actions) in
[https://github.com/marmelroy/PhoneNumberKit/pull/794](https://github.com/marmelroy/PhoneNumberKit/pull/794)
- Rename class `PhoneNumberKit` to `PhoneNumberUtility` by
[@&#8203;HeEAaD](https://github.com/HeEAaD) in
[https://github.com/marmelroy/PhoneNumberKit/pull/798](https://github.com/marmelroy/PhoneNumberKit/pull/798)

#### New Contributors

- [@&#8203;HeEAaD](https://github.com/HeEAaD) made their first
contribution in
[https://github.com/marmelroy/PhoneNumberKit/pull/798](https://github.com/marmelroy/PhoneNumberKit/pull/798)

**Full Changelog**:
marmelroy/PhoneNumberKit@3.8.0...4.0.0

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined),
Automerge - At any time (no schedule defined).

🚦 **Automerge**: Enabled.

♻ **Rebasing**: Whenever PR is behind base branch, or you tick the
rebase/retry checkbox.

👻 **Immortal**: This PR will be recreated if closed unmerged. Get
[config
help](https://github.com/renovatebot/renovate/discussions) if
that's undesired.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR has been generated by [Renovate
Bot](https://github.com/renovatebot/renovate).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzOC45MS4wIiwidXBkYXRlZEluVmVyIjoiMzguOTEuMCIsInRhcmdldEJyYW5jaCI6Im1haW4iLCJsYWJlbHMiOltdfQ==-->

Co-authored-by: cgrindel-self-hosted-renovate[bot] <139595543+cgrindel-self-hosted-renovate[bot]@users.noreply.github.com>
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Swift emits an invalid module interface when a public type has the same name as a module
2 participants