sort unit presets in alphabetical order per coreos#1339

marmijo · Jun 1, 2022 · 3091f01 · marmijo · Jun 1, 2022 · 3091f01
1 parent 163492f
commit 3091f01
Showing 1 changed file with 10 additions and 1 deletion.
diff --git a/internal/exec/stages/files/units.go b/internal/exec/stages/files/units.go
@@ -151,7 +151,16 @@ func (s *stage) createSystemdPresetFile(presets map[string]*Preset) error {
 		return err
 	}
 	hasInstanceUnit := false
-	for _, value := range presets {
+
+	// sort the units before writing to the systemd presets file
+	unitNames := make([]string, 0, len(presets))
+	for unit, _ := range(presets) {
+		unitNames = append(unitNames, unit)
+	}
+	sort.Strings(unitNames)
+
+	for i := range unitNames {
+		value := presets[unitNames[i]]
 		unitString := value.unit
 		if value.instantiatable {
 			hasInstanceUnit = true