Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove deprecated Marp.ready() #145

Merged
merged 2 commits into from
Jan 13, 2020
Merged

Remove deprecated Marp.ready() #145

merged 2 commits into from
Jan 13, 2020

Conversation

yhatt
Copy link
Member

@yhatt yhatt commented Jan 13, 2020

Removed deprecated Marp.ready(). Please use @marp-team/marp-core/browser entrypoint.

⚠️ Marp for VS Code had tried to replace to use @marp-team/marp-core/browser but it did not work caused by rollup's bug (rollup/plugins#102). Whether or not including it to v1 release is still considering.

@yhatt
Copy link
Member Author

yhatt commented Jan 13, 2020

We have to keep classic entrypoint @marp-team/marp-core/lib/browser.cjs to avoid rollup bug.

@yhatt yhatt merged commit f9d4608 into master Jan 13, 2020
@yhatt yhatt deleted the remove-deprecated-marp-ready branch January 13, 2020 02:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant