Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mark Marpit plugin interface as external in rollup #147

Merged
merged 2 commits into from
Jan 17, 2020
Merged

Mark Marpit plugin interface as external in rollup #147

merged 2 commits into from
Jan 17, 2020
+5 −1

Conversation

yhatt
Copy link
Member

@yhatt yhatt commented Jan 17, 2020

A bundled @marp-team/marpit/plugin by rollup has incorrect CommonJS resolving. (rollup/plugins#102)

Marpit is already marked as external dependent module so plugin interface should follow too.

> require('./lib/marp')
{
  Marp: [Function: cn] { html: { br: [] } },
  default: [Function: cn] { html: { br: [] } }
}

Fix #146.

@yhatt yhatt merged commit 2210511 into master Jan 17, 2020
@yhatt yhatt deleted the hotfix-marpit-plugin branch January 17, 2020 14:45
@yhatt yhatt mentioned this pull request Jan 17, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

v1.0.0 throws "z is not a function"
1 participant
@yhatt