fix: upgrade all the dependencies #22
Conversation
exKAZUu
force-pushed
the
update-deps
branch
4 times, most recently
from
8d1bdf0
to
f91a8b3
Compare
test/index.tsx
Outdated
| expect( | ||
| marp | ||
| .text() | ||
| .replace(/!function.*;/, '') |
There was a problem hiding this comment.
This replacement is to remove the polyfill code. (I believe the tests should ignore the polyfill code)
There was a problem hiding this comment.
Marp Core's polyfill should never output in HTML, and be controlled in Marp React. We've already calling polyfill individually in useMarpReady() hook (via useLayoutEffect).
https://github.com/marp-team/marp-react/blob/master/src/hooks/marp-ready.ts
Revert change of test case, and disable script injection through script: false in the option defined by useMarpOptions() hook.
There was a problem hiding this comment.
Do you mean using <Marp markdown={markdown} options={{ script: false }} /> in the tests? Or forcing to change script option to false in Marp.tsx (or marp-options.ts) ?
=>
I've tried adding a new change of the latter approach: #22 (comment)
There was a problem hiding this comment.
And Marp Core peerDependency will require >= v1.0.1.
Line 93 in ab45842
exKAZUu
changed the title
| @@ -24,6 +24,7 @@ export default function useMarpOptions( | |||
| identifier, | |||
| marpOptions: { | |||
| ...(opts || {}), | |||
| script: false, | |||
There was a problem hiding this comment.
I hope this change is what you wanted. (sorry if not)
exKAZUu
changed the title
Close #23
Use worker via CDNdoesn't work both inmasterand this PR because the js file in the CDN is probably too old)