Warn deprecated dollar prefix in global directives #70
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
They are no longer supported in the latest CLI.
yhatt
commented
Sep 16, 2019
| doc.uri, | ||
| new Range(diag.range.start, diag.range.start.translate(0, 1)) | ||
| ) | ||
| // act.isPreferred = true // TODO: Require VS Code >= v1.32 |
There was a problem hiding this comment.
isPreferred is marked as proposal in VS Code v1.31, the least version Marp supported.
https://code.visualstudio.com/updates/v1_31#_auto-fix-and-codeactionispreferred
We should consider bump the least version in another PR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates in the upstream package will break existing Markdown slides that has used
$prefix for global directive. (marp-team/marpit#182)Marp CLI had a time to see warnings for 3 weeks so user could deal with this deprecation. We have already outputted warnings in the developer console of VS Code too, but almost users would have not any chance to notice that.
In Marp for VS Code, we will keep supporting
$prefix against upstream packages, and output warnings through VS Code's Diagnostic API.Added diagnostic support might help migration from the old Marp app too. (marp-team/marp-cli#85)
ToDo
dollarPrefixForGlobalDirectives: Add dollarPrefixForGlobalDirectives option marp-core#104)$theme$style$headingDivider$size(>= v0.13.1)dollarPrefixForGlobalDirectivesoption to engine: Require update)marpdirective astrue$