Run yarn audit while running CI / publish processes #103
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR will run
yarn auditwhile running CI / publish processes. The build would fail if it was found vulnerabilities.This is a security improvement refered in #101.
npm script
prepackandpreversionscript should runyarn audit.npm-run-allcannot run the built-in command of yarn, so we addedcheck-auditscript to runyarn audit.CircleCI
First we consider use
yarn install --audit, but it is not exactly same behavior toyarn installabout the installed package. To run the build within CI as same as before, it is good to addyarn auditcommand.In addition, the built-in docker container provided by node are not containing the latest yarn. We have to upgrade yarn at first for using
yarn audit.